Name color does not update when switching from battle to ctf

[spejsboi]

Retro steps:
1. Change gamemode to battle ("/battle" command) -> name becomes white
2. Change gamemode to ctf ("/ctf" command)

Expected result:
The color of my name updates according to the team that I belong to (blue or red)

Actual result:
Name stays white until I get the flag.

Video:
https://streamable.com/boglnl

[Violet CLM]

Thanks for the report! This has the feel of something that should be easy to fix...

[t3Kev]

this happens vice versa when switching from ctf to battle too

[Violet CLM]

From what I've been able to tell so far, this happens specifically when using a 6.4 client to join servers running 6.3 or below.

[Violet CLM]

Does this fix the problem? (https://get.jj2.plus/misc_builds/plus_64_name_fixes.zip)

[Violet CLM]

Somebody contacted me offsite to say that the above build isn't always working for them. At this point I don't know how many hours I've spent staring at the older name code, trying to figure out what's wrong with it, but my tentative conclusion is that this is not a new problem. If you join a 6.3 CTF server as a 6.3 client, and switch the gamemode to battle, your name colors won't always be right there either. I haven't given up yet, but it's possible there's may be no way to force 6.3 (and below) servers to behave other than for people to stop hosting them.

[Superjazz]

Somebody contacted me offsite to say that the above build isn't always working for them. At this point I don't know how many hours I've spent staring at the older name code, trying to figure out what's wrong with it, but my tentative conclusion is that this is not a new problem. If you join a 6.3 CTF server as a 6.3 client, and switch the gamemode to battle, your name colors won't always be right there either. I haven't given up yet, but it's possible there's may be no way to force 6.3 (and below) servers to behave other than for people to stop hosting them.

Sounds like it might not be necessarily worth it to try to get the fix 100% backward compatible, if the issue doesn't persist in 6.5 <Client-Server> 6.5 combination anymore, but feel free to give it one more try, if you're still up for it.

[Violet CLM]

Version 2 (https://get.jj2.plus/misc_builds/plus_64_name_fixes_v2.zip)

I think this is the solution. I've tested it in the following cases:
Client with colored name joins a 6.3 CTF server that later changes to Battle
Client with colored name joins a 6.3 Battle server that later changes to CTF
Client with non-colored name joins a 6.3 CTF server that later changes to Battle
Client with non-colored name joins a 6.3 Battle server that later changes to CTF
...all successfully. The only case that doesn't work is:

Client with colored name joins a 6.3 CTF server with /joinersspectate enabled that later changes to Battle
But as far as I can tell, this was always broken. It's just as much a problem for 6.3 clients as for 6.5 clients. If someone hosts in 6.4 or 6.5, it'll work, because 6.4 fixed that issue on the server side, but if someone hosts in 6.3, I haven't found a way for the client to convince the server to fix itself.

I haven't tested extensively with gamemodes other than Battle and CTF, because I'm assuming that Race, Treasure Hunt, SP, and Coop all work the same way as Battle, and everything else works the same way as CTF. But that's an untested assumption.

[Superjazz]

Version 2 (https://get.jj2.plus/misc_builds/plus_64_name_fixes_v2.zip)

I think this is the solution. I've tested it in the following cases:
Client with colored name joins a 6.3 CTF server that later changes to Battle
Client with colored name joins a 6.3 Battle server that later changes to CTF
Client with non-colored name joins a 6.3 CTF server that later changes to Battle
Client with non-colored name joins a 6.3 Battle server that later changes to CTF
...all successfully. The only case that doesn't work is:

Client with colored name joins a 6.3 CTF server with /joinersspectate enabled that later changes to Battle

But as far as I can tell, this was always broken. It's just as much a problem for 6.3 clients as for 6.5 clients. If someone hosts in 6.4 or 6.5, it'll work, because 6.4 fixed that issue on the server side, but if someone hosts in 6.3, I haven't found a way for the client to convince the server to fix itself.

I haven't tested extensively with gamemodes other than Battle and CTF, because I'm assuming that Race, Treasure Hunt, SP, and Coop all work the same way as Battle, and everything else works the same way as CTF. But that's an untested assumption.

Yup. This seems to fix it for me as well! Good job! (y)

I tried also switching between a few randomly chosen custom game modes that are based on either Battle/CTF + Race & Treasure, but nothing too complicated to set up.

[Violet CLM]

Good to hear! At some point I hope to see spejsboi reply to these test builds, since this is his thread, but I'm feeling pretty confident about this anyway.

[Violet CLM]

This was implemented in 6.6.